skevy (Adam Miskiewicz)
User

Projects

User Details

User Since
Aug 8 2017, 4:38 PM (14 w, 4 d)

Recent Activity

Sep 28 2017

skevy committed R51:af85d2c12bef: v1.2.0 (authored by skevy).
v1.2.0
Sep 28 2017, 12:37 AM

Sep 14 2017

skevy accepted D3340: Ensure listeners are only notified once per frame.
Sep 14 2017, 4:15 PM
skevy accepted D3339: Made _evaluateSpring take an absolute timestamp.

This seems good 👍

Sep 14 2017, 2:39 PM
skevy added inline comments to D3340: Ensure listeners are only notified once per frame.
Sep 14 2017, 2:39 PM
skevy added inline comments to D3340: Ensure listeners are only notified once per frame.
Sep 14 2017, 2:38 PM
skevy accepted D3341: Consistently use the term "listener" in tests.
Sep 14 2017, 1:36 PM

Sep 13 2017

skevy committed R51:49a3a2f7e331: v1.1.0 (authored by skevy).
v1.1.0
Sep 13 2017, 12:19 AM

Sep 12 2017

skevy accepted D3325: Made onStart synchronous.

👍

Sep 12 2017, 12:49 PM

Sep 11 2017

skevy accepted D3324: Update _currentValue and _currentVelocity before updating fromValue.
Sep 11 2017, 3:37 PM

Aug 15 2017

skevy committed R51:bbc0f831e234: v1.0.0 (authored by skevy).
v1.0.0
Aug 15 2017, 9:34 PM

Aug 14 2017

skevy accepted D3308: Use consistent formatting in all comment blocks.
Aug 14 2017, 10:06 PM
skevy accepted D3304: Only start spring if toValue has changed.
Aug 14 2017, 10:05 PM
skevy committed R51:2d336a517835: Make API clearer re: when spring is at rest (authored by skevy).
Make API clearer re: when spring is at rest
Aug 14 2017, 8:33 PM
skevy closed D3307: Make API clearer re: when spring is at rest by committing R51:2d336a517835: Make API clearer re: when spring is at rest.
Aug 14 2017, 8:33 PM
skevy updated the diff for D3307: Make API clearer re: when spring is at rest.

Fix more nits!

Aug 14 2017, 8:08 PM
skevy added inline comments to D3307: Make API clearer re: when spring is at rest.
Aug 14 2017, 7:56 PM
skevy updated the diff for D3307: Make API clearer re: when spring is at rest.

Fix nits

Aug 14 2017, 7:56 PM
skevy created D3307: Make API clearer re: when spring is at rest.
Aug 14 2017, 7:25 PM
skevy requested changes to D3304: Only start spring if toValue has changed.
Aug 14 2017, 6:17 PM

Aug 13 2017

skevy added a comment to D3304: Only start spring if toValue has changed.

I think if we do this, we should write a test for it.

Aug 13 2017, 1:57 PM
skevy accepted D3305: Fix order of onAtRest.

Thanks!

Aug 13 2017, 1:53 PM

Aug 10 2017

skevy accepted D3303: Add codecov.
Aug 10 2017, 2:01 PM
skevy committed R51:8d42bf360608: Add back babelrc for Jest (authored by skevy).
Add back babelrc for Jest
Aug 10 2017, 1:20 PM
skevy closed D3302: Add back babelrc for Jest by committing R51:8d42bf360608: Add back babelrc for Jest.
Aug 10 2017, 1:20 PM
skevy planned changes to D3302: Add back babelrc for Jest.
Aug 10 2017, 1:19 PM
skevy created D3302: Add back babelrc for Jest.
Aug 10 2017, 1:19 PM
skevy committed R51:22ff5e36a71f: Update various configuration/repo setup (authored by skevy).
Update various configuration/repo setup
Aug 10 2017, 1:10 PM
skevy closed D3301: Update various configuration/repo setup by committing R51:22ff5e36a71f: Update various configuration/repo setup.
Aug 10 2017, 1:10 PM
skevy committed R51:34f0f5e88354: Fixup updateConfig, add tests (authored by skevy).
Fixup updateConfig, add tests
Aug 10 2017, 1:09 PM
skevy closed D3300: Fixup updateConfig, add tests by committing R51:34f0f5e88354: Fixup updateConfig, add tests.
Aug 10 2017, 1:09 PM
skevy added a comment to D3301: Update various configuration/repo setup.

I'm confused about "even if you're not transpiling node_modules". If you're using a tool that walks package.module, what's the advantage of using the rollup build vs. the remove_types one? I don't think you're using any features that need polyfilling in an environment that supports ES modules.

Aug 10 2017, 12:49 PM
skevy updated the diff for D3300: Fixup updateConfig, add tests.

Fix diff?

Aug 10 2017, 12:41 PM
skevy updated the diff for D3300: Fixup updateConfig, add tests.
  • Fix nits
Aug 10 2017, 12:38 PM
skevy committed R51:7a617c30c0e6: Remove concept of "normalizedPosition" and "normalizedVelocity" (authored by skevy).
Remove concept of "normalizedPosition" and "normalizedVelocity"
Aug 10 2017, 5:03 AM
skevy committed R51:2abc28ad5958: Address nits (authored by skevy).
Address nits
Aug 10 2017, 4:59 AM
skevy committed R51:36e2976a202b: Remove concept of "normalizedPosition" and "normalizedVelocity" (authored by skevy).
Remove concept of "normalizedPosition" and "normalizedVelocity"
Aug 10 2017, 4:59 AM
skevy closed D3299: Remove concept of "normalizedPosition" and "normalizedVelocity" by committing R51:36e2976a202b: Remove concept of "normalizedPosition" and "normalizedVelocity".
Aug 10 2017, 4:58 AM
skevy created D3301: Update various configuration/repo setup.
Aug 10 2017, 4:57 AM
skevy updated the diff for D3300: Fixup updateConfig, add tests.

Fix diff again :(

Aug 10 2017, 4:52 AM
skevy updated the diff for D3300: Fixup updateConfig, add tests.

Fix diff

Aug 10 2017, 4:51 AM
skevy updated the diff for D3300: Fixup updateConfig, add tests.
  • clearAllListeners -> removeAllListeners. Update comments/TS defs
Aug 10 2017, 4:48 AM
skevy created D3300: Fixup updateConfig, add tests.
Aug 10 2017, 4:44 AM
skevy updated the diff for D3299: Remove concept of "normalizedPosition" and "normalizedVelocity".

Fix diff

Aug 10 2017, 4:33 AM
skevy added inline comments to D3299: Remove concept of "normalizedPosition" and "normalizedVelocity".
Aug 10 2017, 4:30 AM
skevy updated the diff for D3299: Remove concept of "normalizedPosition" and "normalizedVelocity".
  • Address nits
Aug 10 2017, 4:29 AM

Aug 9 2017

skevy added inline comments to D3299: Remove concept of "normalizedPosition" and "normalizedVelocity".
Aug 9 2017, 8:43 PM
skevy created D3299: Remove concept of "normalizedPosition" and "normalizedVelocity".
Aug 9 2017, 8:41 PM
skevy accepted D3297: Reset currentNormalizedPosition when fromValue is updated.
Aug 9 2017, 2:06 AM
skevy accepted D3298: Fix skipped frames on subsequent starts.
Aug 9 2017, 1:44 AM
skevy committed R51:7600f8a525ba: 0.2.1 (authored by skevy).
0.2.1
Aug 9 2017, 1:11 AM
skevy accepted D3293: Add CI badge.
Aug 9 2017, 1:01 AM
skevy accepted D3290: Inline velocity normalization, to avoid dependency on updateConfig order.
Aug 9 2017, 1:01 AM
skevy committed R51:966638f21d03: v0.2.0 (authored by skevy).
v0.2.0
Aug 9 2017, 12:40 AM

Aug 8 2017

skevy added a comment to D3289: Fix yarn run dist-es to export idiomatic ES modules.

👍

Aug 8 2017, 6:07 PM
skevy added a comment to D3281: Add spring.updateConfig(partialConfig).

I definitely want to, but I've not used jest before, so I'll be a bit slower than I'd be with mocha+chai. Where did you get your snapshots for the existing test? Would be nice to find an iOS or Android harmonic spring and assert that we get similar values out when we put similar ones in.

Aug 8 2017, 6:00 PM
skevy accepted D3285: Move velocity check to start().
Aug 8 2017, 5:55 PM
skevy accepted D3286: Move onAtRest emission to stop().
Aug 8 2017, 5:54 PM
skevy accepted D3284: Add onActive; ensure there's only one rAF running at a time.
Aug 8 2017, 5:54 PM
skevy accepted D3283: Add TypeScript types.

Excellent. Thanks!

Aug 8 2017, 5:49 PM
skevy accepted D3282: Add default value for config.
Aug 8 2017, 5:49 PM
skevy accepted D3281: Add spring.updateConfig(partialConfig).

Any chance you could write a test for this?

Aug 8 2017, 5:49 PM
skevy accepted D3280: Add CI.

Cooool.

Aug 8 2017, 5:47 PM
skevy accepted D3287: Fix currentAnimationFrame test in stop().

This is what I get for not writing a test for stop!

Aug 8 2017, 5:47 PM
skevy accepted D3288: Add JSDoc for public API.

Thanks for this! Hadn't gotten to documenting yet -- thanks for taking on the task!

Aug 8 2017, 5:46 PM
skevy accepted D3289: Fix yarn run dist-es to export idiomatic ES modules.

This is fine.

Aug 8 2017, 5:45 PM
skevy requested changes to D3290: Inline velocity normalization, to avoid dependency on updateConfig order.
Aug 8 2017, 5:42 PM
skevy accepted D3291: Combine springAtRest and isAnimating - they track the same state.

👍 thanks for this. this is what happens when I don't check my work!

Aug 8 2017, 5:40 PM
skevy accepted D3292: Add @license header.
Aug 8 2017, 5:39 PM
skevy accepted D3279: Add yarn run test.

wunderbar.

Aug 8 2017, 4:38 PM