seanoshea (Sean O'Shea)
User

Projects

User does not belong to any projects.
User Since
Aug 22 2016, 9:53 PM (30 w, 1 d)

Recent Activity

Dec 1 2016

seanoshea accepted D2087: Test deprecated Runtime..
Dec 1 2016, 4:11 PM · Material Motion
seanoshea accepted D2085: Make NamedPlan and NamedPerformer abstract subclasses of Plan and Performer..

Really liking how clean this implementation is. Less casting and less references to BasePlans too. Awesome stuff.

Dec 1 2016, 8:52 AM · Material Motion

Nov 21 2016

seanoshea added inline comments to D1905: Add photo album transition example..
Nov 21 2016, 3:18 PM · Material Motion
seanoshea accepted D1979: Add Objective-C API tests..

The FakeDirector example might be a little contrived, but when we're requiring that implementors of MDMTransitionDirector have a setUp method & we're not making use of it in the tests, perhaps we should/could consider making it an optional method in the protocol?

Nov 21 2016, 2:44 PM · Material Motion
seanoshea accepted D1982: Rename PauseSpring to PausesSpring..

Minor variable naming nit.

Nov 21 2016, 2:13 PM · Material Motion
seanoshea added inline comments to D1905: Add photo album transition example..
Nov 21 2016, 1:18 PM · Material Motion
seanoshea added a comment to D1977: Add InteractiveTransitionDirector protocol..

Given that we are exposing a new interface here, should we consider adding some unit tests to ensure that the correct callbacks are invoked when MDMInteractiveTransitionDirectors are used?

Nov 21 2016, 1:07 PM · Material Motion

Nov 10 2016

seanoshea added inline comments to D1655: Draggable plan and gesture detector..
Nov 10 2016, 7:38 PM · Material Motion

Nov 9 2016

seanoshea accepted D1868: Tests for runtime..

We might want to consider putting util classes like StepChoreographer into a separate package other than com.google.android.material.motion.runtime to visually separate it from the actual unit tests. Perhaps as part of https://github.com/material-motion/runtime-android/issues/64. Not a blocker until we figure out a good directory structure for this (or even if we decide to not do this at all)

Nov 9 2016, 4:33 PM · Material Motion

Nov 8 2016

seanoshea committed rMDMRUNTIMEANDROID6096f3a51c33: Adding a logcat tracer. Fixing some issues from initial tracer implementation… (authored by seanoshea).
Adding a logcat tracer. Fixing some issues from initial tracer implementation…
Nov 8 2016, 2:40 PM
seanoshea closed D1887: Adding a logcat tracer. Fixing some issues from initial tracer implementation too. by committing rMDMRUNTIMEANDROID6096f3a51c33: Adding a logcat tracer. Fixing some issues from initial tracer implementation….
Nov 8 2016, 2:40 PM · Material Motion
seanoshea added inline comments to D1887: Adding a logcat tracer. Fixing some issues from initial tracer implementation too..
Nov 8 2016, 8:53 AM · Material Motion
seanoshea committed rMDMRUNTIMEANDROIDa46fa23012a8: Code review comments. Using String.format instead of adding strings together… (authored by seanoshea).
Code review comments. Using String.format instead of adding strings together…
Nov 8 2016, 8:51 AM
seanoshea updated the diff for D1887: Adding a logcat tracer. Fixing some issues from initial tracer implementation too..
  • Code review comments. Using String.format instead of adding strings
Nov 8 2016, 8:51 AM · Material Motion

Nov 7 2016

seanoshea accepted D1886: Update to remixer 0.5.1.
Nov 7 2016, 9:56 PM · Material Motion
seanoshea updated the diff for D1887: Adding a logcat tracer. Fixing some issues from initial tracer implementation too..
  • Adding a new runtime test.
  • Merge branch 'issues/47-logcat-tracer' of github.com:material-motion/material-motion-runtime-android into issues/47-logcat-tracer
  • A new runtime test for adding the same tracer twice.
Nov 7 2016, 9:50 PM · Material Motion
seanoshea committed rMDMRUNTIMEANDROID0ac02d1748c2: A new runtime test for adding the same tracer twice. (authored by seanoshea).
A new runtime test for adding the same tracer twice.
Nov 7 2016, 9:50 PM
seanoshea committed rMDMRUNTIMEANDROIDf57941adc40b: Merge branch 'issues/47-logcat-tracer' of github.com:material-motion/material… (authored by seanoshea).
Merge branch 'issues/47-logcat-tracer' of github.com:material-motion/material…
Nov 7 2016, 9:50 PM
seanoshea committed rMDMRUNTIMEANDROID9eef9f54f174: Adding a new runtime test. (authored by seanoshea).
Adding a new runtime test.
Nov 7 2016, 9:50 PM
seanoshea committed rMDMRUNTIMEANDROID149322cc4351: Adding a logcat tracer. Fixing some issues from initial tracer implementation… (authored by seanoshea).
Adding a logcat tracer. Fixing some issues from initial tracer implementation…
Nov 7 2016, 9:50 PM
seanoshea retitled D1887: Adding a logcat tracer. Fixing some issues from initial tracer implementation too. from to Adding a logcat tracer. Fixing some issues from initial tracer implementation too..
Nov 7 2016, 9:32 PM · Material Motion
seanoshea committed rMDMRUNTIMEANDROIDf9eef34f4ef9: Adding a logcat tracer. Fixing some issues from initial tracer implementation… (authored by seanoshea).
Adding a logcat tracer. Fixing some issues from initial tracer implementation…
Nov 7 2016, 9:30 PM
seanoshea committed rMDMRUNTIMEANDROID4e89ead26181: Initial tracing implementation. (authored by seanoshea).
Initial tracing implementation.
Nov 7 2016, 8:10 PM
seanoshea closed D1880: Initial tracing implementation. by committing rMDMRUNTIMEANDROID4e89ead26181: Initial tracing implementation..
Nov 7 2016, 8:10 PM · Material Motion
seanoshea added inline comments to D1880: Initial tracing implementation..
Nov 7 2016, 6:58 PM · Material Motion
seanoshea updated the diff for D1880: Initial tracing implementation..
  • Code review comments. Aligning this a little closer to Java naming
Nov 7 2016, 6:55 PM · Material Motion
seanoshea committed rMDMRUNTIMEANDROIDb9b2e38fb920: Code review comments. Aligning this a little closer to Java naming… (authored by seanoshea).
Code review comments. Aligning this a little closer to Java naming…
Nov 7 2016, 6:55 PM
seanoshea committed rMDMRUNTIMEOBJC15f9e7295fd5: Merge branch 'issues/114-tracer-callback-ordering' of github.com:material… (authored by seanoshea).
Merge branch 'issues/114-tracer-callback-ordering' of github.com:material…
Nov 7 2016, 9:01 AM
seanoshea committed rMDMRUNTIMEOBJC2b70ca04d5dc: Per issue #114 - Swapping the ordering of when the tracer callbacks happen. (authored by seanoshea).
Per issue #114 - Swapping the ordering of when the tracer callbacks happen.
Nov 7 2016, 9:01 AM
seanoshea committed rMDMRUNTIMEOBJC28d7afd18b7b: Per issue #114 - Swapping the ordering of when the tracer callbacks happen. (authored by seanoshea).
Per issue #114 - Swapping the ordering of when the tracer callbacks happen.
Nov 7 2016, 9:00 AM
seanoshea closed D1882: Per issue #114 - Swapping the ordering of when the tracer callbacks happen. Performers are created before plans can be added so it makes sense that the tracer callbacks should follow this same ordering. by committing rMDMRUNTIMEOBJC28d7afd18b7b: Per issue #114 - Swapping the ordering of when the tracer callbacks happen..
Nov 7 2016, 9:00 AM · Material Motion

Nov 6 2016

seanoshea committed rMDMRUNTIMEOBJC45c9f6633c35: Per issue #114 - Swapping the ordering of when the tracer callbacks happen. (authored by seanoshea).
Per issue #114 - Swapping the ordering of when the tracer callbacks happen.
Nov 6 2016, 3:54 PM
seanoshea retitled D1882: Per issue #114 - Swapping the ordering of when the tracer callbacks happen. Performers are created before plans can be added so it makes sense that the tracer callbacks should follow this same ordering. from to Per issue #114 - Swapping the ordering of when the tracer callbacks happen. Performers are created before plans can be added so it makes sense that the tracer callbacks should follow this same ordering..
Nov 6 2016, 3:45 PM · Material Motion
seanoshea added inline comments to D1880: Initial tracing implementation..
Nov 6 2016, 12:02 PM · Material Motion
seanoshea updated the diff for D1880: Initial tracing implementation..
  • Performer notifications should happen before addPlan callbacks.
Nov 6 2016, 12:00 PM · Material Motion
seanoshea committed rMDMRUNTIMEANDROID1262b1d193d9: Performer notifications should happen before addPlan callbacks. (authored by seanoshea).
Performer notifications should happen before addPlan callbacks.
Nov 6 2016, 12:00 PM
seanoshea updated the diff for D1880: Initial tracing implementation..
  • Initial tracing implementation.
  • Splitting this out into a separate review.
Nov 6 2016, 10:14 AM · Material Motion
seanoshea committed rMDMRUNTIMEANDROID3ffa3dea111a: Splitting this out into a separate review. (authored by seanoshea).
Splitting this out into a separate review.
Nov 6 2016, 10:12 AM
seanoshea added inline comments to rMDMRUNTIMEANDROID89acc6ca2bc8: Initial tracing implementation..
Nov 6 2016, 9:48 AM
seanoshea committed rMDMRUNTIMEANDROID89acc6ca2bc8: Initial tracing implementation. (authored by seanoshea).
Initial tracing implementation.
Nov 6 2016, 9:29 AM
seanoshea retitled D1880: Initial tracing implementation. from to Initial tracing implementation..
Nov 6 2016, 9:26 AM · Material Motion

Nov 4 2016

seanoshea accepted D1867: TargetScope tests..

Could be worthwhile considering breaking those plans out into separate classes in their own right if they can be used across a few types of unit tests.

Nov 4 2016, 9:53 AM · Material Motion

Nov 3 2016

seanoshea committed rMDMRUNTIMEOBJC602ef5302e3b: Alter the order of when the performer and tracer callbacks are invoked. (authored by seanoshea).
Alter the order of when the performer and tracer callbacks are invoked.
Nov 3 2016, 2:07 PM
seanoshea closed D1859: Alter the order of when the performer and tracer callbacks are invoked. by committing rMDMRUNTIMEOBJC602ef5302e3b: Alter the order of when the performer and tracer callbacks are invoked..
Nov 3 2016, 2:06 PM · Material Motion
seanoshea committed rMDMRUNTIMEOBJC78f3d6f3a146: Per issue #110 - Altering the order of when the performer and tracer… (authored by seanoshea).
Per issue #110 - Altering the order of when the performer and tracer…
Nov 3 2016, 2:04 PM
seanoshea committed rMDMRUNTIMEOBJC6823127b100e: Per #110 Trying again with performer and tracer tests. (authored by seanoshea).
Per #110 Trying again with performer and tracer tests.
Nov 3 2016, 2:04 PM
seanoshea committed rMDMRUNTIMEOBJCaf065bec84ed: Merge branch 'issues/110-performers-tracers' of github.com:material… (authored by seanoshea).
Merge branch 'issues/110-performers-tracers' of github.com:material…
Nov 3 2016, 2:04 PM
seanoshea retitled D1859: Alter the order of when the performer and tracer callbacks are invoked. from to Per issue #110 - Altering the order of when the performer and tracer callbacks are invoked..
Nov 3 2016, 1:53 PM · Material Motion
seanoshea committed rMDMRUNTIMEOBJC050ec20a4bff: Merge branch 'issues/110-performers-tracers' of github.com:material… (authored by seanoshea).
Merge branch 'issues/110-performers-tracers' of github.com:material…
Nov 3 2016, 1:48 PM
seanoshea committed rMDMRUNTIMEOBJCddcd1f416c0b: Per issue #110 - Altering the order of when the performer and tracer… (authored by seanoshea).
Per issue #110 - Altering the order of when the performer and tracer…
Nov 3 2016, 1:48 PM
seanoshea committed rMDMRUNTIMEOBJCe15a94cb955d: Per issue #110 - Altering the order of when the performer and tracer… (authored by seanoshea).
Per issue #110 - Altering the order of when the performer and tracer…
Nov 3 2016, 1:47 PM

Nov 2 2016

seanoshea accepted D1849: Fix the life of a plan example..
Nov 2 2016, 2:19 PM · Material Motion

Nov 1 2016

seanoshea added a comment to D1827: Rename Scheduler to Runtime..

I think we could rename TestSchedulerDelegate.swift to TestRuntimeDelegate.swift too?

Nov 1 2016, 4:14 PM · Material Motion
seanoshea added a comment to D1827: Rename Scheduler to Runtime..

I think there are a few references to the Scheduler in the README as well. Could be worthwhile to pot them over to being runtime along with links like:

1. [How to commit a plan to a scheduler](#how-to-commit-a-plan-to-a-scheduler)
Nov 1 2016, 4:03 PM · Material Motion

Oct 31 2016

seanoshea committed rMDMRUNTIMEOBJC4131ea17c798: Added a Logging Tracer. (authored by seanoshea).
Added a Logging Tracer.
Oct 31 2016, 5:53 PM
seanoshea closed D1810: Added a Logging Tracer. by committing rMDMRUNTIMEOBJC4131ea17c798: Added a Logging Tracer..
Oct 31 2016, 5:53 PM · Material Motion
seanoshea committed rMDMRUNTIMEOBJCcac0c975324f: Merge branch 'issues/105-logging-tracer' of github.com:material… (authored by seanoshea).
Merge branch 'issues/105-logging-tracer' of github.com:material…
Oct 31 2016, 5:52 PM
seanoshea committed rMDMRUNTIMEOBJCfc195fc50240: Ensuring that the new ConsoleLoggingTracer is available in the public API. (authored by seanoshea).
Ensuring that the new ConsoleLoggingTracer is available in the public API.
Oct 31 2016, 5:52 PM
seanoshea updated the diff for D1810: Added a Logging Tracer..
  • Merge branch 'issues/105-logging-tracer' of github.com:material-motion/material-motion-runtime-objc into issues/105-logging-tracer
  • Ensuring that the new ConsoleLoggingTracer is available in the public API.
Oct 31 2016, 5:47 PM · Material Motion
seanoshea committed rMDMRUNTIMEOBJCfa24b841376a: Ensuring that the new ConsoleLoggingTracer is available in the public API. (authored by seanoshea).
Ensuring that the new ConsoleLoggingTracer is available in the public API.
Oct 31 2016, 5:44 PM
seanoshea committed rMDMRUNTIMEOBJC212d7e3a53b5: Merge branch 'issues/105-logging-tracer' of github.com:material… (authored by seanoshea).
Merge branch 'issues/105-logging-tracer' of github.com:material…
Oct 31 2016, 5:42 PM
seanoshea committed rMDMRUNTIMEOBJCce6156f77c88: Code review changes. Moving towards ConsoleLoggingTracer. (authored by seanoshea).
Code review changes. Moving towards ConsoleLoggingTracer.
Oct 31 2016, 5:42 PM
seanoshea updated the diff for D1810: Added a Logging Tracer..
  • Merge branch 'issues/105-logging-tracer' of github.com:material-motion/material-motion-runtime-objc into issues/105-logging-tracer
  • Code review changes. Moving towards ConsoleLoggingTracer.
Oct 31 2016, 3:17 PM · Material Motion
seanoshea committed rMDMRUNTIMEOBJC30314e177a1c: Code review changes. Moving towards ConsoleLoggingTracer. (authored by seanoshea).
Code review changes. Moving towards ConsoleLoggingTracer.
Oct 31 2016, 3:15 PM
seanoshea committed rMDMRUNTIMEOBJCb32fc876a765: Merge branch 'issues/105-logging-tracer' of github.com:material… (authored by seanoshea).
Merge branch 'issues/105-logging-tracer' of github.com:material…
Oct 31 2016, 12:07 PM
seanoshea committed rMDMRUNTIMEOBJC668b970047de: Merge branch 'issues/105-logging-tracer' of github.com:material… (authored by seanoshea).
Merge branch 'issues/105-logging-tracer' of github.com:material…
Oct 31 2016, 12:07 PM
seanoshea added inline comments to D1810: Added a Logging Tracer..
Oct 31 2016, 12:04 PM · Material Motion
seanoshea updated the diff for D1810: Added a Logging Tracer..
  • Code review comments. Adding some documentation to LoggingTracer and separating out some plan notification logic too.
  • Merge branch 'issues/105-logging-tracer' of github.com:material-motion/material-motion-runtime-objc into issues/105-logging-tracer
Oct 31 2016, 12:02 PM · Material Motion
seanoshea committed rMDMRUNTIMEOBJC31a49781a63c: Merge branch 'issues/105-logging-tracer' of github.com:material… (authored by seanoshea).
Merge branch 'issues/105-logging-tracer' of github.com:material…
Oct 31 2016, 12:00 PM
seanoshea committed rMDMRUNTIMEOBJC28a1a3ac8003: Adding a Logging Tracer. (authored by seanoshea).
Adding a Logging Tracer.
Oct 31 2016, 12:00 PM
seanoshea committed rMDMRUNTIMEOBJCfa8a3bdcab42: Code review comments. Adding some documentation to LoggingTracer and… (authored by seanoshea).
Code review comments. Adding some documentation to LoggingTracer and…
Oct 31 2016, 12:00 PM
seanoshea retitled D1810: Added a Logging Tracer. from to Adding a Logging Tracer..
Oct 31 2016, 9:31 AM · Material Motion

Oct 30 2016

seanoshea committed rMDMRUNTIMEOBJC341c448335ba: Adding some assertions for the logging tracer tests. (authored by seanoshea).
Adding some assertions for the logging tracer tests.
Oct 30 2016, 11:16 PM
seanoshea committed rMDMRUNTIMEOBJCbcf9a9ac204f: First pass at a logging tracer. Need to verify that NSLog is getting invoked… (authored by seanoshea).
First pass at a logging tracer. Need to verify that NSLog is getting invoked…
Oct 30 2016, 10:05 PM

Oct 28 2016

seanoshea accepted D1792: Restructure Plan/Performer types..

Looks good to me.

Oct 28 2016, 4:06 PM · Material Motion
seanoshea added a comment to D1795: Fix TargetScope.commitAddNamedPlan()..

Looks a lot closer to the Objective-C implementation. My bad on forgetting about the target in the initial named plan implementation.

Oct 28 2016, 10:01 AM · Material Motion
seanoshea accepted D1795: Fix TargetScope.commitAddNamedPlan()..
Oct 28 2016, 9:34 AM · Material Motion
seanoshea added inline comments to D1792: Restructure Plan/Performer types..
Oct 28 2016, 9:15 AM · Material Motion
seanoshea committed rMDMRUNTIMEOBJC5f09efda840b: Port named plan changes from Android runtime. (authored by seanoshea).
Port named plan changes from Android runtime.
Oct 28 2016, 9:00 AM
seanoshea committed rMDMRUNTIMEOBJCabc2c9dd17d1: Merge branch 'issues/107-named-plans-changes' of github.com:material… (authored by seanoshea).
Merge branch 'issues/107-named-plans-changes' of github.com:material…
Oct 28 2016, 9:00 AM
seanoshea committed rMDMRUNTIMEOBJCad07342a9610: Port named plan changes from Android runtime. (authored by seanoshea).
Port named plan changes from Android runtime.
Oct 28 2016, 9:00 AM
seanoshea closed D1787: Port named plan changes from Android runtime. by committing rMDMRUNTIMEOBJCad07342a9610: Port named plan changes from Android runtime..
Oct 28 2016, 9:00 AM · Material Motion

Oct 27 2016

appsforartists awarded D1787: Port named plan changes from Android runtime. a Party Time token.
Oct 27 2016, 5:32 PM · Material Motion
seanoshea retitled D1787: Port named plan changes from Android runtime. from to Port named plan changes from Android runtime..
Oct 27 2016, 5:21 PM · Material Motion
seanoshea committed rMDMRUNTIMEOBJC9ccb36795cfe: Not creating performers when calling removeNamedPlan:from. (authored by seanoshea).
Not creating performers when calling removeNamedPlan:from.
Oct 27 2016, 4:58 PM

Oct 25 2016

GitHub <noreply@github.com> committed rMDMRUNTIMEANDROID4544360b75a5: Adding and Removing Named Plans. Deprecating Transaction and adding plans… (authored by seanoshea).
Adding and Removing Named Plans. Deprecating Transaction and adding plans…
Oct 25 2016, 8:55 PM
GitHub <noreply@github.com> committed rMDMRUNTIMEANDROIDabc1f3dd79c1: Merge ea49d4ec16f170153aec683a118f8a3a6f719b6e into… (authored by seanoshea).
Merge ea49d4ec16f170153aec683a118f8a3a6f719b6e into…
Oct 25 2016, 8:44 PM
seanoshea committed rMDMRUNTIMEANDROIDea49d4ec16f1: Reverting to working copy from develop. (authored by seanoshea).
Reverting to working copy from develop.
Oct 25 2016, 8:44 PM
GitHub <noreply@github.com> committed rMDMRUNTIMEANDROIDf4ba3bd31f41: Merge 476f66f1f94b3b60bda8d088115e308f47e79b7f into… (authored by seanoshea).
Merge 476f66f1f94b3b60bda8d088115e308f47e79b7f into…
Oct 25 2016, 8:37 PM
seanoshea committed rMDMRUNTIMEANDROID476f66f1f94b: Code review comments. Deprecating Transaction. (authored by seanoshea).
Code review comments. Deprecating Transaction.
Oct 25 2016, 8:37 PM
GitHub <noreply@github.com> committed rMDMRUNTIMEANDROID32cf7eab2f3a: Merge 5bcb3db25bb84253372f97fa9dd34c6a58b08f71 into… (authored by seanoshea).
Merge 5bcb3db25bb84253372f97fa9dd34c6a58b08f71 into…
Oct 25 2016, 8:31 PM
seanoshea committed rMDMRUNTIMEANDROID5bcb3db25bb8: Per issue #52 - Adding these back. (authored by seanoshea).
Per issue #52 - Adding these back.
Oct 25 2016, 8:31 PM
GitHub <noreply@github.com> committed rMDMRUNTIMEANDROIDd605d206c006: Merge defd3db99ff4e7367b1de47e5b509e8af974db04 into… (authored by seanoshea).
Merge defd3db99ff4e7367b1de47e5b509e8af974db04 into…
Oct 25 2016, 8:17 PM
GitHub <noreply@github.com> committed rMDMRUNTIMEANDROID50b362269533: Merge defd3db99ff4e7367b1de47e5b509e8af974db04 into… (authored by seanoshea).
Merge defd3db99ff4e7367b1de47e5b509e8af974db04 into…
Oct 25 2016, 8:07 PM
seanoshea committed rMDMRUNTIMEANDROIDdefd3db99ff4: Per issue #34 - mimicking the travis file at https://github. (authored by seanoshea).
Per issue #34 - mimicking the travis file at https://github.
Oct 25 2016, 8:06 PM
GitHub <noreply@github.com> committed rMDMRUNTIMEANDROID87e84bbe6795: Merge 14b30445b71468f9dd1f379894c379e2fdfd4e03 into… (authored by seanoshea).
Merge 14b30445b71468f9dd1f379894c379e2fdfd4e03 into…
Oct 25 2016, 8:02 PM
seanoshea committed rMDMRUNTIMEANDROID14b30445b714: Per issue #34 - Trimming this out. (authored by seanoshea).
Per issue #34 - Trimming this out.
Oct 25 2016, 8:02 PM
GitHub <noreply@github.com> committed rMDMRUNTIMEANDROID869ad0a997b3: Merge 019d815e27839e9e78254cf1837ffe5794a4caa1 into… (authored by seanoshea).
Merge 019d815e27839e9e78254cf1837ffe5794a4caa1 into…
Oct 25 2016, 7:51 PM
seanoshea committed rMDMRUNTIMEANDROID019d815e2783: Merging from develop. (authored by seanoshea).
Merging from develop.
Oct 25 2016, 7:51 PM
seanoshea accepted D1772: Move integration tests to unit tests..
Oct 25 2016, 7:28 PM · Material Motion