Feed All Stories

Today

featherless created D3136: Mark all MotionObservable subscribe methods with @discardableResult..
Fri, Apr 28, 5:38 PM · Material Motion
appsforartists added a comment to D3131: [added] MotionSubject.

I intend to use properties in all the same places you are. I don't expect to use MotionSubjects in any user-facing code (only for testing). Still, it's nice from an organizational point of view to have all the Motion types in the same place as the types they wrap.

Fri, Apr 28, 5:03 PM · Material Motion
appsforartists added a comment to D3129: [added] MotionProperty.

Name are always changeable (e.g. we can rename ReactiveProperty to OperableProperty and then use ReactiveProperty for what's currently MotionProperty).

Fri, Apr 28, 4:58 PM · Material Motion
appsforartists retitled D3133: [moved] properties into observables from [refactored] properties into observables to [moved] properties into observables.
Fri, Apr 28, 4:51 PM · Material Motion
featherless added a comment to D3131: [added] MotionSubject.

It'll make the unit tests simpler: I can replace the mockObserver + MotionObservable pair with a single MotionSubject.

https://github.com/material-motion/material-motion-js/issues/208

Fri, Apr 28, 4:31 PM · Material Motion
featherless accepted D3130: [fixed] system to be optional in DraggableArgs.

Ah, this just means you don't have to provide an argument. Cool.

Fri, Apr 28, 4:30 PM · Material Motion
appsforartists requested review of D3131: [added] MotionSubject.

It'll make the unit tests simpler: I can replace the mockObserver + MotionObservable pair with a single MotionSubject.

Fri, Apr 28, 4:29 PM · Material Motion
appsforartists requested review of D3130: [fixed] system to be optional in DraggableArgs.

There's already a default set on line 53 - it defaults to the dragSystem I wrote.

Fri, Apr 28, 4:27 PM · Material Motion
featherless accepted D3135: [refactored] SpringT to Spring.
Fri, Apr 28, 3:42 PM · Material Motion
featherless accepted D3128: [added] Operable interface.
Fri, Apr 28, 3:42 PM · Material Motion
featherless requested changes to D3129: [added] MotionProperty.

Is it possible to have a ReactiveProperty type that implements the MotionObservable operators?

Fri, Apr 28, 3:39 PM · Material Motion
featherless requested changes to D3130: [fixed] system to be optional in DraggableArgs.

What's the default behavior if there's no system?

Fri, Apr 28, 3:38 PM · Material Motion
featherless requested changes to D3131: [added] MotionSubject.

What's this for? I'm still not certain why this is necessary when we have ReactiveProperty.

Fri, Apr 28, 3:38 PM · Material Motion
featherless accepted D3132: [changed] ObservableWithOperators types to interfaces.
Fri, Apr 28, 3:37 PM · Material Motion
featherless accepted D3133: [moved] properties into observables.

Is this a refactor? Looks like you've just moved the files around?

Fri, Apr 28, 3:36 PM · Material Motion
featherless accepted D3134: [upgraded] to TypeScript 2.3.
Fri, Apr 28, 3:33 PM · Material Motion
featherless accepted D3127: [fixed] dragSystem dispatching the same value twice on pointerup.
Fri, Apr 28, 3:30 PM · Material Motion
featherless accepted D3126: [changed] enums to be string consts.
Fri, Apr 28, 3:29 PM · Material Motion
GitHub <noreply@github.com> committed rNIMBUSa4f1266ed7dd: Merge 3fdb0548401b9531a653e318b89a8198d655ed52 into… (authored by Alexander Hoekje List <atlex2@gmail.com>).
Merge 3fdb0548401b9531a653e318b89a8198d655ed52 into…
Fri, Apr 28, 6:21 AM
GitHub <noreply@github.com> committed rNIMBUSa2943cf0c59d: Merge 5da18905d5de26490feb084901c12d6c8c7c9ab6 into… (authored by Moonbeom Kyle KWON <maskkwon@gmail.com>).
Merge 5da18905d5de26490feb084901c12d6c8c7c9ab6 into…
Fri, Apr 28, 6:21 AM
GitHub <noreply@github.com> committed rNIMBUS862fa9a74ff4: Merge e9d28947f994c6c8e77a622cc9f67fdaba5ac8c6 into… (authored by Paul Knopf <pauldotknopf@gmail.com>).
Merge e9d28947f994c6c8e77a622cc9f67fdaba5ac8c6 into…
Fri, Apr 28, 6:21 AM
GitHub <noreply@github.com> committed rNIMBUS3e7449c9241a: Merge d7c81825c6688f26d80b227df6ae3dbb38bbdd4b into… (authored by Adar Porat <aporat@users.noreply.github.com>).
Merge d7c81825c6688f26d80b227df6ae3dbb38bbdd4b into…
Fri, Apr 28, 6:21 AM
GitHub <noreply@github.com> committed rNIMBUS08a060df5330: Merge 710a1250c58c35fbd7533f6b552fb0330e056853 into… (authored by Yuhao Ding <yding202@gmail.com>).
Merge 710a1250c58c35fbd7533f6b552fb0330e056853 into…
Fri, Apr 28, 6:21 AM

Yesterday

Restricted Application failed to build Restricted Buildable for D3135: [refactored] SpringT to Spring.
Thu, Apr 27, 10:49 PM · Material Motion
Restricted Application failed to build Restricted Buildable for D3134: [upgraded] to TypeScript 2.3.
Thu, Apr 27, 10:49 PM · Material Motion
Restricted Application failed to build Restricted Buildable for D3133: [moved] properties into observables.
Thu, Apr 27, 10:48 PM · Material Motion
Restricted Application failed to build Restricted Buildable for D3132: [changed] ObservableWithOperators types to interfaces.
Thu, Apr 27, 10:48 PM · Material Motion
Restricted Application failed to build Restricted Buildable for D3131: [added] MotionSubject.
Thu, Apr 27, 10:46 PM · Material Motion
Restricted Application failed to build Restricted Buildable for D3130: [fixed] system to be optional in DraggableArgs.
Thu, Apr 27, 10:46 PM · Material Motion
Restricted Application failed to build Restricted Buildable for D3129: [added] MotionProperty.
Thu, Apr 27, 10:45 PM · Material Motion
Restricted Application failed to build Restricted Buildable for D3128: [added] Operable interface.
Thu, Apr 27, 10:45 PM · Material Motion
appsforartists created D3135: [refactored] SpringT to Spring.
Thu, Apr 27, 10:45 PM · Material Motion
appsforartists created D3134: [upgraded] to TypeScript 2.3.
Thu, Apr 27, 10:44 PM · Material Motion
appsforartists created D3133: [moved] properties into observables.
Thu, Apr 27, 10:44 PM · Material Motion
appsforartists created D3132: [changed] ObservableWithOperators types to interfaces.
Thu, Apr 27, 10:44 PM · Material Motion
appsforartists created D3131: [added] MotionSubject.
Thu, Apr 27, 10:43 PM · Material Motion
appsforartists created D3130: [fixed] system to be optional in DraggableArgs.
Thu, Apr 27, 10:43 PM · Material Motion
appsforartists created D3129: [added] MotionProperty.
Thu, Apr 27, 10:43 PM · Material Motion
appsforartists created D3128: [added] Operable interface.
Thu, Apr 27, 10:43 PM · Material Motion
appsforartists committed R13:8ed8ac504223: [added] getPointerEventStreamsFromElement(element) (authored by appsforartists).
[added] getPointerEventStreamsFromElement(element)
Thu, Apr 27, 5:32 PM
appsforartists closed D3122: [added] getPointerEventStreamsFromElement(element) by committing R13:8ed8ac504223: [added] getPointerEventStreamsFromElement(element).
Thu, Apr 27, 5:32 PM · Material Motion
appsforartists committed R13:8d9a3d39b8d1: [added] convertTouchEventsToPointerEvents(touchEvent$) (authored by appsforartists).
[added] convertTouchEventsToPointerEvents(touchEvent$)
Thu, Apr 27, 5:32 PM
appsforartists closed D3120: [added] convertTouchEventsToPointerEvents(touchEvent$) by committing R13:8d9a3d39b8d1: [added] convertTouchEventsToPointerEvents(touchEvent$).
Thu, Apr 27, 5:32 PM · Material Motion
appsforartists committed R13:b8201425c5e2: [added] motionObservable._flattenIterables(); (authored by appsforartists).
[added] motionObservable._flattenIterables();
Thu, Apr 27, 5:32 PM
appsforartists closed D3119: [added] motionObservable._flattenIterables(); by committing R13:b8201425c5e2: [added] motionObservable._flattenIterables();.
Thu, Apr 27, 5:31 PM · Material Motion
appsforartists committed R13:dd5219e92ffa: [reverted] writing CHANGED to state on every move (authored by appsforartists).
[reverted] writing CHANGED to state on every move
Thu, Apr 27, 5:31 PM
appsforartists closed D3118: [reverted] writing CHANGED to state on every move by committing R13:dd5219e92ffa: [reverted] writing CHANGED to state on every move.
Thu, Apr 27, 5:31 PM · Material Motion
appsforartists committed R13:9a594f2159f2: [added] unit tests for motionObservable.velocity() (authored by appsforartists).
[added] unit tests for motionObservable.velocity()
Thu, Apr 27, 5:31 PM
appsforartists closed D3110: [added] unit tests for motionObservable.velocity() by committing R13:9a594f2159f2: [added] unit tests for motionObservable.velocity().
Thu, Apr 27, 5:31 PM · Material Motion
appsforartists committed R13:101d93646245: [refactored] useMockedRAF to use new sinon stub API (authored by appsforartists).
[refactored] useMockedRAF to use new sinon stub API
Thu, Apr 27, 5:31 PM
appsforartists closed D3109: [refactored] useMockedRAF to use new sinon stub API by committing R13:101d93646245: [refactored] useMockedRAF to use new sinon stub API.
Thu, Apr 27, 5:31 PM · Material Motion
appsforartists committed R13:82c1546e8695: [added] useMockedPerformance (authored by appsforartists).
[added] useMockedPerformance
Thu, Apr 27, 5:26 PM
appsforartists committed R13:8d9606b478c9: [added] motionObservable.velocity(pulse) (authored by appsforartists).
[added] motionObservable.velocity(pulse)
Thu, Apr 27, 5:26 PM
appsforartists closed D3108: [added] useMockedPerformance by committing R13:82c1546e8695: [added] useMockedPerformance.
Thu, Apr 27, 5:26 PM · Material Motion
appsforartists closed D3107: [added] motionObservable.velocity(pulse) by committing R13:8d9606b478c9: [added] motionObservable.velocity(pulse).
Thu, Apr 27, 5:26 PM · Material Motion
Restricted Application failed to build Restricted Buildable for D3122: [added] getPointerEventStreamsFromElement(element).
Thu, Apr 27, 5:20 PM · Material Motion
appsforartists updated the diff for D3122: [added] getPointerEventStreamsFromElement(element).

Made dragSystem more evident

Thu, Apr 27, 5:17 PM · Material Motion
Restricted Application failed to build Restricted Buildable for D3127: [fixed] dragSystem dispatching the same value twice on pointerup.
Thu, Apr 27, 5:17 PM · Material Motion
Restricted Application failed to build Restricted Buildable for D3126: [changed] enums to be string consts.
Thu, Apr 27, 5:17 PM · Material Motion
appsforartists created D3127: [fixed] dragSystem dispatching the same value twice on pointerup.
Thu, Apr 27, 5:14 PM · Material Motion
appsforartists created D3126: [changed] enums to be string consts.
Thu, Apr 27, 5:14 PM · Material Motion
appsforartists added a comment to D3125: Shorten the delayBy test delay..

Sweet.

Thu, Apr 27, 4:57 PM · Material Motion
featherless committed rREACTIVEMOTIONSWIFT3d8d91d60532: WIP of reactive scroll. (authored by featherless).
WIP of reactive scroll.
Thu, Apr 27, 4:49 PM
featherless committed rREACTIVEMOTIONSWIFT811475403a22: WIP of reactive scroll. (authored by featherless).
WIP of reactive scroll.
Thu, Apr 27, 4:49 PM
featherless committed rREACTIVEMOTIONSWIFTbe0ea019c4d2: Add a new Reactive type for querying reactive properties. (authored by featherless).
Add a new Reactive type for querying reactive properties.
Thu, Apr 27, 3:29 PM
featherless closed D3112: Add a new Reactive type for querying reactive properties. by committing rREACTIVEMOTIONSWIFTbe0ea019c4d2: Add a new Reactive type for querying reactive properties..
Thu, Apr 27, 3:29 PM · Material Motion
featherless updated the diff for D3112: Add a new Reactive type for querying reactive properties..
  • Touchup docs.
Thu, Apr 27, 3:26 PM · Material Motion
randcode-generator accepted D3112: Add a new Reactive type for querying reactive properties..
Thu, Apr 27, 3:22 PM · Material Motion
featherless updated the diff for D3112: Add a new Reactive type for querying reactive properties..
  • Simplify test.
  • Move Reactive to its own file.
Thu, Apr 27, 3:03 PM · Material Motion
featherless committed rREACTIVEMOTIONSWIFT67cb7b18dccc: Shorten the delayBy test delay. (authored by featherless).
Shorten the delayBy test delay.
Thu, Apr 27, 2:25 PM
featherless closed D3125: Shorten the delayBy test delay. by committing rREACTIVEMOTIONSWIFT67cb7b18dccc: Shorten the delayBy test delay..
Thu, Apr 27, 2:25 PM · Material Motion
featherless added a comment to D3125: Shorten the delayBy test delay..

Is .milliseconds(10) using the fancy new sugar that Eric proposed last week?

Thu, Apr 27, 2:24 PM · Material Motion
appsforartists added inline comments to D3122: [added] getPointerEventStreamsFromElement(element).
Thu, Apr 27, 1:43 PM · Material Motion
appsforartists added a comment to D3125: Shorten the delayBy test delay..

Is .milliseconds(10) using the fancy new sugar that Eric proposed last week?

Thu, Apr 27, 1:33 PM · Material Motion
appsforartists accepted D3125: Shorten the delayBy test delay..
Thu, Apr 27, 1:32 PM · Material Motion
featherless created D3125: Shorten the delayBy test delay..
Thu, Apr 27, 1:31 PM · Material Motion
randcode-generator committed rREACTIVEMOTIONSWIFT9c5010e54b83: Added new start function to MotionRuntime (authored by randcode-generator).
Added new start function to MotionRuntime
Thu, Apr 27, 1:30 PM
randcode-generator closed D3117: Added new start function to MotionRuntime by committing rREACTIVEMOTIONSWIFT9c5010e54b83: Added new start function to MotionRuntime.
Thu, Apr 27, 1:29 PM · Material Motion
featherless committed rREACTIVEMOTIONSWIFTd584666c449e: Reduce flakiness of delay test. (authored by featherless).
Reduce flakiness of delay test.
Thu, Apr 27, 1:28 PM
featherless closed D3114: Reduce flakiness of delay test. by committing rREACTIVEMOTIONSWIFTd584666c449e: Reduce flakiness of delay test..
Thu, Apr 27, 1:28 PM · Material Motion
featherless accepted D3122: [added] getPointerEventStreamsFromElement(element).

Yay! Am curious what the system looks like at this point - can you throw together a draw.io diagram?

Thu, Apr 27, 1:27 PM · Material Motion
randcode-generator retitled D3117: Added new start function to MotionRuntime from Added new start api to Added new start function to MotionRuntime.
Thu, Apr 27, 1:25 PM · Material Motion
randcode-generator retitled D3117: Added new start function to MotionRuntime from added new start api to Added new start api.
Thu, Apr 27, 1:24 PM · Material Motion
featherless accepted D3107: [added] motionObservable.velocity(pulse).

Epic.

Thu, Apr 27, 1:23 PM · Material Motion
featherless accepted D3119: [added] motionObservable._flattenIterables();.
Thu, Apr 27, 1:21 PM · Material Motion
featherless accepted D3118: [reverted] writing CHANGED to state on every move.
Thu, Apr 27, 1:20 PM · Material Motion
featherless accepted D3117: Added new start function to MotionRuntime.
Thu, Apr 27, 1:20 PM · Material Motion
featherless committed rREACTIVEMOTIONSWIFTf83c027067fe: Move Timeline to a timeline folder. (authored by featherless).
Move Timeline to a timeline folder.
Thu, Apr 27, 1:17 PM
featherless closed D3115: Move Timeline to a timeline folder. by committing rREACTIVEMOTIONSWIFTf83c027067fe: Move Timeline to a timeline folder..
Thu, Apr 27, 1:16 PM · Material Motion
featherless accepted D3120: [added] convertTouchEventsToPointerEvents(touchEvent$).
Thu, Apr 27, 1:12 PM · Material Motion
featherless committed rREACTIVEMOTIONSWIFT7adfe1798432: Bump IndefiniteObservable to 4.0 and add explicit unsubscriptions to the… (authored by featherless).
Bump IndefiniteObservable to 4.0 and add explicit unsubscriptions to the…
Thu, Apr 27, 1:10 PM
featherless closed D3124: Bump IndefiniteObservable to 4.0 and add explicit unsubscriptions to the runtime. by committing rREACTIVEMOTIONSWIFT7adfe1798432: Bump IndefiniteObservable to 4.0 and add explicit unsubscriptions to the….
Thu, Apr 27, 1:10 PM · Material Motion
appsforartists added inline comments to D3120: [added] convertTouchEventsToPointerEvents(touchEvent$).
Thu, Apr 27, 1:10 PM · Material Motion
appsforartists accepted D3115: Move Timeline to a timeline folder..
Thu, Apr 27, 1:04 PM · Material Motion
appsforartists accepted D3124: Bump IndefiniteObservable to 4.0 and add explicit unsubscriptions to the runtime..
Thu, Apr 27, 1:03 PM · Material Motion
featherless created D3124: Bump IndefiniteObservable to 4.0 and add explicit unsubscriptions to the runtime..
Thu, Apr 27, 12:59 PM · Material Motion
featherless committed rREACTIVEMOTIONSWIFT1bc8df0d15fd: WIP of no unsubscription. (authored by featherless).
WIP of no unsubscription.
Thu, Apr 27, 11:59 AM
featherless committed rREACTIVEMOTIONSWIFTb47e7ce33067: WIP of improved property access. (authored by featherless).
WIP of improved property access.
Thu, Apr 27, 11:59 AM
featherless committed rREACTIVEMOTIONSWIFTa3784865732e: Simplify test. (authored by featherless).
Simplify test.
Thu, Apr 27, 11:59 AM
featherless committed rREACTIVEMOTIONSWIFT73d5189d2a94: Move Timeline to a timeline folder. (authored by featherless).
Move Timeline to a timeline folder.
Thu, Apr 27, 11:59 AM