Make API clearer re: when spring is at rest

Authored by skevy on Aug 14 2017, 8:08 PM.

Description

Make API clearer re: when spring is at rest

Summary:
The public API was confusing with regards to when the spring at rest, and didn't differentiate between "is animating" and "is at rest".

Changes overview:

  • isAtRest and isAnimating are public getters
  • onActive -> onStart, onAtRest -> onStop
  • Added test for stop/onStop

Test Plan: Run the tests! :)

Reviewers: appsforartists

Reviewed By: appsforartists

Differential Revision: http://codereview.cc/D3307

Details

Committed
skevyAug 14 2017, 8:33 PM
Reviewer
appsforartists
Differential Revision
D3307: Make API clearer re: when spring is at rest
Parents
R51:c658cec9ea05: Fix order of onAtRest
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/11411