• Changed Files
  • packages/core/src/operators/rewrite.ts

[refactored] rewrite to have options

Authored by appsforartists on Tue, Sep 5, 10:16 PM.

Description

[refactored] rewrite to have options

Summary:
Not sure what the right pattern is for operator APIs. Some (like rewriteTo) will likely never need options, so requiring every operator to use the named args pattern would be noisey, but consistent. Passing an options dict as the last arg is messier, but avoids cluttering the APIs that don't need options.

For now, I care more about functionality than API design, so I'm using an options dict.

Reviewers: O2 Material Motion, O3 Material JavaScript platform reviewers, Material Motion, featherless

Reviewed By: O2 Material Motion, Material Motion, featherless

Tags: Material Motion

Differential Revision: http://codereview.cc/D3315

Details

Committed
appsforartistsTue, Sep 12, 5:14 PM
Reviewer
O2: Material Motion
Differential Revision
D3315: [refactored] rewrite to have options
Parents
R13:eeca207d37d0: [changed] rewriteRange to accept reactive arguments
Branches
Unknown
Tags
Unknown