Continuation of https://github.com/material-motion/material-motion-js/issues/193
- Group Reviewers
- R13:21b7c4c04a58: [refactored] _tap to use named args
I don't have a formatting strategy yet. Will probably add clang-format or prettier at some point, but haven't gotten there yet.
I'm not sure I follow. On lines 30 and 48, I see <D, T, U> in both.
I see, I didn't expand the code and didn't see the definition on line 30.
Another reason I had this comment because in all your other files, you have swapped the 2 generic types T and D, such as _ReactiveNextOperatorArgs in _reactiveNextOperator.ts or Operation<T, D> in types.ts but not here. Therefore, I want to doublecheck if this is as you intended.