[renamed] subscribe({ to }) to subscribe({ source })
ClosedPublic

Authored by appsforartists on Oct 6 2017, 1:01 AM.

Details

Summary

to had potential to be confusing. While you are subscribing to the source, it could also be interpretted to mean the property being written to. By using explicit names sink and source, there's no room for ambiguity.

Diff Detail

Repository
R13 material-motion/material-motion-js
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
appsforartists created this revision.Oct 6 2017, 1:01 AM
Restricted Application added a reviewer: O2: Material Motion. · View Herald TranscriptOct 6 2017, 1:01 AM
Restricted Application added a project: Material Motion. · View Herald Transcript
Restricted Application added a reviewer: O3: Material JavaScript platform reviewers. · View Herald Transcript
Restricted Application added a reviewer: Material Motion. · View Herald Transcript
Restricted Application completed building Restricted Buildable.Oct 6 2017, 1:04 AM
featherless accepted this revision.Oct 6 2017, 1:57 PM
This revision is now accepted and ready to land.Oct 6 2017, 1:57 PM
This revision was automatically updated to reflect the committed changes.