[fixed] type errors in operators and helper functions
ClosedPublic

Authored by appsforartists on Sep 25 2017, 11:38 PM.

Details

Summary

For instance:

  • Removed type parameters from calls to proxies. (May revise this in the future to try to prevent the proxies abstraction from leaking, but for now, I just care about a clean build.
  • Used type parameters to specify U in terms of T & (ExpectedUpstreamType) where possible.
  • Made all signatures use ObservableWithMotionOperators signature, rather than setting expectations about which concrete type is returned.

Diff Detail

Repository
R13 material-motion/material-motion-js
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a reviewer: O2: Material Motion. · View Herald TranscriptSep 25 2017, 11:38 PM
Restricted Application added a project: Material Motion. · View Herald Transcript
Restricted Application added a reviewer: O3: Material JavaScript platform reviewers. · View Herald Transcript
Restricted Application added a reviewer: Material Motion. · View Herald Transcript
Restricted Application failed to build Restricted Buildable!Sep 25 2017, 11:43 PM

Fixed combineStyleStreams

Restricted Application failed to build Restricted Buildable!Sep 26 2017, 1:06 AM

Added types to proxies

Restricted Application completed building Restricted Buildable.Sep 26 2017, 1:52 AM
Restricted Application failed to build Restricted Buildable!Sep 26 2017, 1:55 AM
featherless accepted this revision.Oct 6 2017, 2:05 PM
This revision is now accepted and ready to land.Oct 6 2017, 2:05 PM
This revision was automatically updated to reflect the committed changes.