[added] swipeState$ to Swipeable
ClosedPublic

Authored by appsforartists on Sep 13 2017, 9:48 PM.

Details

Summary

Gives the author the ability to know when an action has occurred.

When I wrote this, I was imagining using it to animate the sibling items after one has been dismissed, but since I haven't gotten there yet, I'm not sure if this will prove to be a useful way to model that behavior. navState$ has been useful for other interactions, so I think there's promise in the ___state$ abstraction.

Diff Detail

Repository
R13 material-motion/material-motion-js
Branch
swipe-away (branched from develop)
Lint
Lint OK
Unit
No Unit Test Coverage
appsforartists created this revision.Sep 13 2017, 9:48 PM
Restricted Application added a reviewer: O2: Material Motion. · View Herald TranscriptSep 13 2017, 9:48 PM
Restricted Application added a project: Material Motion. · View Herald Transcript
Restricted Application added a reviewer: O3: Material JavaScript platform reviewers. · View Herald Transcript
Restricted Application added a reviewer: Material Motion. · View Herald Transcript
Restricted Application completed building Restricted Buildable.Sep 13 2017, 9:52 PM
Restricted Application failed to build Restricted Buildable!
appsforartists edited the summary of this revision. (Show Details)Sep 19 2017, 7:24 PM
featherless accepted this revision.Fri, Oct 6, 9:20 AM
featherless added a subscriber: featherless.
featherless added inline comments.
packages/core/src/interactions/Swipeable.ts
57

This may have to include other swipe directions in the future if this supports swiping up or down as well.

This revision is now accepted and ready to land.Fri, Oct 6, 9:20 AM
This revision was automatically updated to reflect the committed changes.