• Changed Files
  • packages/core/src/interactions/Tossable.ts

[removed] tossable.resistanceProgress$
ClosedPublic

Authored by appsforartists on Mon, Sep 11, 10:04 PM.

Details

Summary

In Swipeable, we want to know whether a drag has crossed a threshold (e,g, resistanceProgress === 1); however, when it crosses the threshold, resistanceFactor is set to 0. Since resistanceProgress$ depends on resistanceFactor$, it's not a reliable way of measuring if the threshold has been crossed.

Thus, I'm rolling back resistanceProgress$ (D3326) and using a threshold in Swipeable instead.

Diff Detail

Repository
R13 material-motion/material-motion-js
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a reviewer: O2: Material Motion. · View Herald TranscriptMon, Sep 11, 10:04 PM
Restricted Application added a project: Material Motion. · View Herald Transcript
Restricted Application added a reviewer: O3: Material JavaScript platform reviewers. · View Herald Transcript
Restricted Application added a reviewer: Material Motion. · View Herald Transcript
Restricted Application failed to build Restricted Buildable!Mon, Sep 11, 10:25 PM
appsforartists edited the summary of this revision. (Show Details)Tue, Sep 19, 6:56 PM
featherless accepted this revision.Wed, Sep 20, 5:51 PM
This revision is now accepted and ready to land.Wed, Sep 20, 5:51 PM
This revision was automatically updated to reflect the committed changes.