• Changed Files
  • packages/core/src/operators/rewrite.ts

[refactored] rewrite to have options
ClosedPublic

Authored by appsforartists on Wed, Sep 6, 8:26 PM.

Details

Summary

Not sure what the right pattern is for operator APIs. Some (like rewriteTo) will likely never need options, so requiring every operator to use the named args pattern would be noisey, but consistent. Passing an options dict as the last arg is messier, but avoids cluttering the APIs that don't need options.

For now, I care more about functionality than API design, so I'm using an options dict.

Diff Detail

Repository
R13 material-motion/material-motion-js
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
appsforartists created this revision.Wed, Sep 6, 8:26 PM
Restricted Application added a reviewer: O2: Material Motion. · View Herald TranscriptWed, Sep 6, 8:26 PM
Restricted Application added a project: Material Motion. · View Herald Transcript
Restricted Application added a reviewer: O3: Material JavaScript platform reviewers. · View Herald Transcript
Restricted Application added a reviewer: Material Motion. · View Herald Transcript
Restricted Application completed building Restricted Buildable.Wed, Sep 6, 8:29 PM
featherless accepted this revision.Tue, Sep 12, 4:40 PM
This revision is now accepted and ready to land.Tue, Sep 12, 4:40 PM
This revision was automatically updated to reflect the committed changes.