Add spring.updateConfig(partialConfig)
ClosedPublic

Authored by appsforartists on Aug 8 2017, 5:17 PM.

Diff Detail

Repository
R51 wobble
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
appsforartists created this revision.Aug 8 2017, 5:17 PM
Restricted Application added a reviewer: skevy. · View Herald TranscriptAug 8 2017, 5:17 PM
Restricted Application completed building Restricted Buildable.Aug 8 2017, 5:19 PM
skevy accepted this revision.Aug 8 2017, 5:49 PM

Fantastic!

Any chance you could write a test for this?

This revision is now accepted and ready to land.Aug 8 2017, 5:49 PM

I definitely want to, but I've not used jest before, so I'll be a bit slower than I'd be with mocha+chai. Where did you get your snapshots for the existing test? Would be nice to find an iOS or Android harmonic spring and assert that we get similar values out when we put similar ones in.

This revision was automatically updated to reflect the committed changes.
skevy added a comment.Aug 8 2017, 6:00 PM

I definitely want to, but I've not used jest before, so I'll be a bit slower than I'd be with mocha+chai. Where did you get your snapshots for the existing test? Would be nice to find an iOS or Android harmonic spring and assert that we get similar values out when we put similar ones in.

Re snapshots for the existing test -- I took them using the jest snapshot API (.matchSnapshot). It's basically just a regression test -- we're assuming the values that are currently in the snapshot are actually correct.

I agree about matching against the ios spring -- but that's going to be pretty hard. I'd have to go through frame-by-frame and dump the memory registers :)