[added] inner stream support to `rewrite`
AcceptedPublic

Authored by appsforartists on May 25 2017, 6:07 PM.

Details

Summary

For instance:

state$.rewrite({
  closed: height$.offsetBy(-56),
  preview: height$.offsetBy(-300),
  open: 0,
}).subscribe(spring.destination);

will position a sheet in the correct place if height$ changes, or if state$ changes.

Diff Detail

Repository
R13 material-motion/material-motion-js
Branch
carousel (branched from develop)
Lint
Lint OK
Unit
No Unit Test Coverage
appsforartists created this revision.May 25 2017, 6:07 PM
Restricted Application added a reviewer: O2: Material Motion. · View Herald TranscriptMay 25 2017, 6:07 PM
Restricted Application added a project: Material Motion. · View Herald Transcript
Restricted Application added a reviewer: O3: Material JavaScript platform reviewers. · View Herald Transcript
Restricted Application added a reviewer: Material Motion. · View Herald Transcript
Restricted Application completed building Restricted Buildable.May 25 2017, 6:09 PM

The old implementation automatically cast incoming values to strings when needed to index a dictionary. This adds a test (and fix) for that.

Updating D3250: [added] inner stream support to rewrite

For instance:

state$.rewrite({
  closed: height$.offsetBy(-56),
  preview: height$.offsetBy(-300),
  open: 0,
}).subscribe(spring.destination);

will position a sheet in the correct place if...

Restricted Application completed building Restricted Buildable.May 25 2017, 6:31 PM
Restricted Application completed building Restricted Buildable.May 25 2017, 6:34 PM
appsforartists retitled this revision from [added] inner stream support to `rewrite` For instance: ``` state$.rewrite({ closed: height$.offsetBy(-56), preview: height$.offsetBy(-300), open: 0, }).subscribe(spring.destination); ``` will position a sheet in the correct place if... to [added] inner stream support to `rewrite`.May 26 2017, 1:39 PM
appsforartists edited the summary of this revision. (Show Details)
featherless accepted this revision.May 30 2017, 5:10 PM
This revision is now accepted and ready to land.May 30 2017, 5:10 PM