[refactored] springSystem(Spring) into NumericReboundSpring interaction
ClosedPublic

Authored by appsforartists on May 23 2017, 9:45 PM.

Diff Detail

Repository
R13 material-motion/material-motion-js
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
appsforartists created this revision.May 23 2017, 9:45 PM
Restricted Application added a reviewer: O2: Material Motion. · View Herald TranscriptMay 23 2017, 9:45 PM
Restricted Application added a project: Material Motion. · View Herald Transcript
Restricted Application added a reviewer: O3: Material JavaScript platform reviewers. · View Herald Transcript
Restricted Application added a reviewer: Material Motion. · View Herald Transcript
Restricted Application completed building Restricted Buildable.May 23 2017, 9:47 PM

Removing needless .read() calls

Restricted Application completed building Restricted Buildable.May 23 2017, 10:27 PM
featherless added inline comments.
packages/springs-rebound/src/__tests__/NumericReboundSpring.test.ts
77

Setting the destination shouldn't immediately change the value of the spring - is this test running the simulation somehow?

appsforartists added inline comments.May 25 2017, 3:26 PM
packages/springs-rebound/src/__tests__/NumericReboundSpring.test.ts
77

Yeah - line 61 sets it to be synchronous for testing.

featherless accepted this revision.May 25 2017, 3:27 PM
This revision is now accepted and ready to land.May 25 2017, 3:27 PM
This revision was automatically updated to reflect the committed changes.