Differential D3224

Don't attempt to slow down CASpringAnimation animations when slow-motion animations is enabled.
ClosedPublic
Actions

Authored by featherless on May 15 2017, 2:01 PM.

Details

Reviewers
appsforartists
Group Reviewers
O2: Material Motion
O4: Material Apple platform reviewers
Material Motion
Commits
rREACTIVEMOTIONSWIFT9d796f374bfb: Don't attempt to slow down CASpringAnimation animations when slow-motion…
Summary

CASpringAnimation can't be slowed down by modifying its duration.

Diff Detail

Repository
rREACTIVEMOTIONSWIFT reactive-motion-swift
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
featherless created this revision.May 15 2017, 2:01 PM
Restricted Application added a reviewer: O2: Material Motion. · View Herald TranscriptMay 15 2017, 2:01 PM
Restricted Application added a project: Material Motion. · View Herald Transcript
Restricted Application added a reviewer: O4: Material Apple platform reviewers. · View Herald Transcript
Restricted Application added a reviewer: Material Motion. · View Herald Transcript
featherless edited the summary of this revision. (Show Details)May 15 2017, 2:02 PM
appsforartists accepted this revision.May 15 2017, 8:36 PM
This revision is now accepted and ready to land.May 15 2017, 8:36 PM
appsforartists added a comment.May 15 2017, 8:37 PM

Are there useful ways to dilate time with a CA spring?

featherless added a comment.May 15 2017, 8:49 PM
In D3224#59813, @appsforartists wrote:

Are there useful ways to dilate time with a CA spring?

Only by modifying the layer speed, which is a good deal more invasive.

markwei added a subscriber: markwei.May 15 2017, 8:57 PM
In D3224#59818, @featherless wrote:
In D3224#59813, @appsforartists wrote:

Are there useful ways to dilate time with a CA spring?

Only by modifying the layer speed, which is a good deal more invasive.

This might be a crazy idea, but we could modulate tension and friction such that the damping ratio is constant.

featherless added a comment.May 15 2017, 9:03 PM
In D3224#59819, @markwei wrote:
In D3224#59818, @featherless wrote:
In D3224#59813, @appsforartists wrote:

Are there useful ways to dilate time with a CA spring?

Only by modifying the layer speed, which is a good deal more invasive.

This might be a crazy idea, but we could modulate tension and friction such that the damping ratio is constant.

Haha yes, am open to that as a possible solution :)

Closed by commit rREACTIVEMOTIONSWIFT9d796f374bfb: Don't attempt to slow down CASpringAnimation animations when slow-motion… (authored by featherless). · Explain WhyMay 16 2017, 12:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

Diff 11193

View Options

src/reactivetypes/Reactive+CALayer.swift

Loading...