added more unit tests
ClosedPublic

Authored by randcode-generator on Tue, May 9, 3:16 PM.

Diff Detail

Repository
rMDMSTREAMSANDROID reactive-motion-android
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a reviewer: O2: Material Motion. · View Herald TranscriptTue, May 9, 3:16 PM
Restricted Application added a project: Material Motion. · View Herald Transcript
Restricted Application added a reviewer: O6: Material Android platform reviewers. · View Herald Transcript
Restricted Application added a reviewer: Material Motion. · View Herald Transcript
Restricted Application failed to build Restricted Buildable!Tue, May 9, 3:20 PM
markwei requested changes to this revision.Tue, May 9, 3:59 PM
markwei added a subscriber: markwei.

Can you add a comment on why the xLockedTo and yLockedTo tests don't pass? https://circleci.com/gh/material-motion/material-motion-android/207

library/src/test/java/com/google/android/material/motion/operators/StartWithTest.java
38 ↗(On Diff #11090)

can you rename to StartWithTests?

This revision now requires changes to proceed.Tue, May 9, 3:59 PM

There was a bug in lockToXAxis and lockToYAxis. The change didn't get pushed yet so that's why the those tests failed.

randcode-generator marked an inline comment as done.Tue, May 9, 10:02 PM
Restricted Application failed to build Restricted Buildable!Tue, May 9, 10:05 PM
markwei accepted this revision.Tue, May 9, 10:09 PM
This revision is now accepted and ready to land.Tue, May 9, 10:09 PM
This revision was automatically updated to reflect the committed changes.