Added new start function to MotionRuntime
ClosedPublic

Authored by randcode-generator on May 4 2017, 5:09 PM.

Details

Summary

Added a new start function to MotionRuntime that will allow interaction B to start when interaction A is at certain state (active or atRest)

Fixes https://github.com/material-motion/material-motion-android/issues/80

Diff Detail

Repository
rMDMSTREAMSANDROID reactive-motion-android
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a reviewer: O2: Material Motion. · View Herald TranscriptMay 4 2017, 5:09 PM
Restricted Application added a project: Material Motion. · View Herald Transcript
Restricted Application added a reviewer: O6: Material Android platform reviewers. · View Herald Transcript
Restricted Application added a reviewer: Material Motion. · View Herald Transcript
randcode-generator retitled this revision from added new start runtime to Added new start function to MotionRuntime.May 4 2017, 5:10 PM
randcode-generator edited the summary of this revision. (Show Details)
Restricted Application completed building Restricted Buildable.May 4 2017, 5:14 PM
markwei requested changes to this revision.May 4 2017, 5:23 PM
markwei added a subscriber: markwei.
markwei added inline comments.
library/src/main/java/com/google/android/material/motion/MotionRuntime.java
18

remove unused imports

109
110

be careful about type safety here. Your IDE should be highlighting this section in yellow to warn you that you are using unsafe types. You can fix this by following these comments:

111

Interaction should be Interaction<?, ?>

111

Change Integer to int

112

MotionObservable should be MotionObservable<Boolean>

113

these changes should allow you to remove <Integer> here

This revision now requires changes to proceed.May 4 2017, 5:23 PM
randcode-generator marked 7 inline comments as done.May 4 2017, 5:34 PM
Restricted Application completed building Restricted Buildable.May 4 2017, 5:38 PM
markwei accepted this revision.May 4 2017, 5:40 PM
markwei added inline comments.
library/src/main/java/com/google/android/material/motion/MotionRuntime.java
109

Still need to change the documentation above

112

no space: MotionObservable<Boolean>

This revision is now accepted and ready to land.May 4 2017, 5:40 PM
This revision was automatically updated to reflect the committed changes.