Cleanup Source superclass.
ClosedPublic

Authored by markwei on May 2 2017, 9:11 PM.

Details

Summary

Fix onDisconnect() not being called anywhere.
Remove observer from onEnabled() and onDisabled()
Make onDisconnect() a required method.

Improve TweenSource implementation to parity with PhysicsSpringSource.
Now correctly removes listeners when an observer disconnects.

Diff Detail

Repository
rMDMSTREAMSANDROID reactive-motion-android
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
markwei created this revision.May 2 2017, 9:11 PM
Restricted Application added a reviewer: O2: Material Motion. · View Herald TranscriptMay 2 2017, 9:11 PM
Restricted Application added a project: Material Motion. · View Herald Transcript
Restricted Application added a reviewer: O6: Material Android platform reviewers. · View Herald Transcript
Restricted Application added a reviewer: Material Motion. · View Herald Transcript
Restricted Application completed building Restricted Buildable.May 2 2017, 9:11 PM
Restricted Application completed building Restricted Buildable.May 2 2017, 9:16 PM
featherless accepted this revision.May 3 2017, 11:08 AM
This revision is now accepted and ready to land.May 3 2017, 11:08 AM
This revision was automatically updated to reflect the committed changes.