[added] motionObservable.delayBy(timeInMS)
ClosedPublic

Authored by appsforartists on Apr 17 2017, 6:24 PM.

Diff Detail

Repository
R13 material-motion/material-motion-js
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
appsforartists created this revision.Apr 17 2017, 6:24 PM
Restricted Application added a reviewer: O2: Material Motion. · View Herald TranscriptApr 17 2017, 6:24 PM
Restricted Application added a project: Material Motion. · View Herald Transcript
Restricted Application added a reviewer: O3: Material JavaScript platform reviewers. · View Herald Transcript
Restricted Application added a reviewer: Material Motion. · View Herald Transcript
Restricted Application completed building Restricted Buildable.Apr 17 2017, 6:26 PM
markwei requested changes to this revision.Apr 17 2017, 6:28 PM
markwei added a subscriber: markwei.
markwei added inline comments.
packages/core/src/operators/delayBy.ts
62

same issue as android's initial impl http://codereview.cc/D3026?vs=10669&id=10729&whitespace=ignore-most#toc

"if we connect, disconnect, and then connect again before the first connection's delayed event fired, it's possible that both connections will fire"

This revision now requires changes to proceed.Apr 17 2017, 6:28 PM

Adding test to verify Android bug isn't reproducible here

Restricted Application completed building Restricted Buildable.Apr 17 2017, 6:47 PM
markwei accepted this revision.Apr 17 2017, 6:51 PM
This revision is now accepted and ready to land.Apr 17 2017, 6:51 PM
This revision was automatically updated to reflect the committed changes.