Implement slop operator
ClosedPublic

Authored by markwei on Wed, Apr 5, 8:43 PM.

Diff Detail

Repository
rMDMSTREAMSANDROID reactive-motion-android
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
markwei created this revision.Wed, Apr 5, 8:43 PM
Restricted Application added a reviewer: O2: Material Motion. · View Herald TranscriptWed, Apr 5, 8:43 PM
Restricted Application added a project: Material Motion. · View Herald Transcript
Restricted Application added a reviewer: O6: Material Android platform reviewers. · View Herald Transcript
Restricted Application added a reviewer: Material Motion. · View Herald Transcript

@featherless I did not follow the implementation instructions in https://material-motion.github.io/material-motion/starmap/specifications/operators/slop. In fact, I didn't quite understand why properties and valves were involved. Can you please make sure this impl is equivalent?

Restricted Application failed to build Restricted Buildable!Wed, Apr 5, 8:45 PM
featherless accepted this revision.Sat, Apr 8, 8:04 PM

Ah! This is awesome. Want to update the spec and I'll simplify the Swift implementation accordingly?

This revision is now accepted and ready to land.Sat, Apr 8, 8:04 PM

Ah! This is awesome. Want to update the spec and I'll simplify the Swift implementation accordingly?

Done. https://material-motion.github.io/material-motion/starmap/specifications/operators/slop

This revision was automatically updated to reflect the committed changes.