Change the reactive object cache to use ObjectIdentifier as the key and consolidate the caches to one dictionary.
ClosedPublic

Authored by featherless on Mon, Mar 13, 3:23 PM.

Details

Summary

This ensures that we support subclasses. Fixes https://github.com/material-motion/reactive-motion-swift/issues/46

Test Plan

Ran the unit tests before this change, verified that they failed.

After this change, the unit tests pass.

Diff Detail

Repository
rREACTIVEMOTIONSWIFT reactive-motion-swift
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
featherless created this revision.Mon, Mar 13, 3:23 PM
  • Add tests.
featherless edited the test plan for this revision. (Show Details)Mon, Mar 13, 3:30 PM
chuga accepted this revision.Mon, Mar 13, 4:12 PM
chuga added a subscriber: chuga.
chuga added inline comments.
src/MotionRuntime.swift
117

r/layer/scrollView here and below

This revision is now accepted and ready to land.Mon, Mar 13, 4:12 PM
featherless marked an inline comment as done.Mon, Mar 13, 4:19 PM
This revision was automatically updated to reflect the committed changes.