100% coverage of ReactiveProperty.
ClosedPublic

Authored by featherless on Mar 9 2017, 3:09 PM.

Diff Detail

Repository
rREACTIVEMOTIONSWIFT reactive-motion-swift
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
featherless created this revision.Mar 9 2017, 3:09 PM
chuga requested changes to this revision.Mar 10 2017, 11:27 AM
chuga added a subscriber: chuga.
chuga added inline comments.
tests/unit/ReactivePropertyTests.swift
73

I'm not sure this is testing the right thing 🤔 isn't it being fulfilled as soon as you call property.subscribe?

This revision now requires changes to proceed.Mar 10 2017, 11:27 AM
featherless added inline comments.Mar 10 2017, 11:31 AM
tests/unit/ReactivePropertyTests.swift
73

Added docs explaining what's going on here.

chuga accepted this revision.Mar 10 2017, 11:32 AM
This revision is now accepted and ready to land.Mar 10 2017, 11:32 AM
This revision was automatically updated to reflect the committed changes.