[added] ThresholdSide
ClosedPublic

Authored by appsforartists on Wed, Mar 8, 8:07 PM.

Details

Summary

Constants needed to support threshold, thresholdRange, and slidingThreshold

Diff Detail

Repository
R13 material-motion/material-motion-js
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
appsforartists created this revision.Wed, Mar 8, 8:07 PM
Restricted Application failed to build Restricted Buildable!Wed, Mar 8, 8:12 PM

using lowercase for enum values

Restricted Application failed to build Restricted Buildable!Wed, Mar 22, 4:58 PM
featherless requested changes to this revision.Wed, Mar 22, 5:57 PM
featherless added a subscriber: featherless.
featherless added inline comments.
packages/experimental-addons/src/ThresholdSide.ts
24

Swift API is called ThresholdEvent with when- prefix on each name. Intentional deviation here?

This revision now requires changes to proceed.Wed, Mar 22, 5:57 PM
appsforartists added inline comments.Wed, Mar 22, 6:07 PM
packages/experimental-addons/src/ThresholdSide.ts
24

The docs all used the .above shorthand, so I didn't know the name of the object they were on. Events are built into the standard library of JS, so I'd prefer not to use that suffix for things that aren't bubbling UI events.

Let's chat in person.

appsforartists requested review of this revision.Wed, Mar 22, 7:42 PM
appsforartists marked 2 inline comments as done.
appsforartists added inline comments.
appsforartists marked an inline comment as done.

Rebasing on ts-loader

Restricted Application completed building Restricted Buildable.Wed, Mar 22, 8:48 PM
Restricted Application completed building Restricted Buildable.Wed, Mar 22, 8:51 PM
markwei accepted this revision.Tue, Mar 28, 4:49 PM
markwei added a subscriber: markwei.
markwei added inline comments.
packages/experimental-addons/src/ThresholdSide.ts
18

typo

appsforartists added inline comments.Tue, Mar 28, 5:19 PM
packages/experimental-addons/src/ThresholdSide.ts
18

Thanks; will fix!

featherless accepted this revision.Wed, Mar 29, 12:16 AM
This revision is now accepted and ready to land.Wed, Mar 29, 12:16 AM
This revision was automatically updated to reflect the committed changes.