Remove TransitionInteraction type.
ClosedPublic

Authored by featherless on Mar 7 2017, 3:30 PM.

Details

Summary

This type was introducing more complications than it was solving. We were using a specialized runtime.add method to support transition interactions. This works so long as the type of the interaction is known to be a transition interaction at call time. If the interaction is typed as a property interaction, e.g. let spring: Spring = TransitionSpring, then the wrong method will be invoked and our transition setup code won't be executed.

This change removes the transition type and moves the special logic into the interaction's add method instead.

Diff Detail

Repository
rREACTIVEMOTIONSWIFT reactive-motion-swift
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
featherless created this revision.Mar 7 2017, 3:30 PM
markwei accepted this revision.Mar 7 2017, 6:25 PM
This revision is now accepted and ready to land.Mar 7 2017, 6:25 PM
This revision was automatically updated to reflect the committed changes.