Creates a TimelineView in /supplemental
ClosedPublic

Authored by chuga on Tue, Feb 28, 3:33 PM.

Diff Detail

Repository
rREACTIVEMOTIONSWIFT reactive-motion-swift
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
chuga created this revision.Tue, Feb 28, 3:33 PM
chuga updated this revision to Diff 10123.Tue, Feb 28, 3:44 PM
  • Minor fix
chuga planned changes to this revision.Wed, Mar 1, 11:27 AM
chuga updated this revision to Diff 10125.Wed, Mar 1, 11:30 AM
  • Move TimelineView into src/ and fix use of zero()
featherless accepted this revision.Wed, Mar 1, 11:32 AM
This revision is now accepted and ready to land.Wed, Mar 1, 11:32 AM
This revision was automatically updated to reflect the committed changes.
featherless added inline comments.Wed, Mar 1, 11:33 AM
src/supplemental/TimelineView.swift
79

It might help the education of this demo if you use a delegate pattern to keep all material motion-related code in the main source file.

E.g. Fire a delegate call here and change the timeline's enabled state in the main source file instead.

chuga added inline comments.Wed, Mar 1, 11:42 AM
src/supplemental/TimelineView.swift
79

That's true, will do in a follow up CL
In the future we should probably wrap this view in its own controller