Only keep one animation at a time
ClosedPublic

Authored by chuga on Feb 24 2017, 3:03 PM.

Diff Detail

Repository
rREACTIVEMOTIONSWIFT reactive-motion-swift
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
chuga created this revision.Feb 24 2017, 3:03 PM
featherless requested changes to this revision.Feb 24 2017, 3:04 PM
featherless added a subscriber: featherless.
featherless added inline comments.
src/systems/coreAnimationPathTweenToStream.swift
34

I suppose we can just keep and reuse one key now; perhaps we don't need to remove the animation either because core animation will blow away the existing same-keyed animation.

52

Does this completion block get invoked when we remove the animation? We might need to pass a "did complete" arg to this block if so.

This revision now requires changes to proceed.Feb 24 2017, 3:04 PM
chuga updated this revision to Diff 10109.Feb 24 2017, 3:50 PM
  • Keep track of animations
chuga added inline comments.Feb 24 2017, 3:51 PM
src/systems/coreAnimationPathTweenToStream.swift
52

I added back activeAnimations, changing the completion block to pass a didComplete bool would be way more work

featherless accepted this revision.Feb 24 2017, 4:20 PM
This revision is now accepted and ready to land.Feb 24 2017, 4:20 PM
This revision was automatically updated to reflect the committed changes.