Add composable performer guide to README.md.
ClosedPublic

Authored by featherless on Sep 13 2016, 3:44 PM.

Diff Detail

Repository
rMDMRUNTIMEOBJC material-motion/runtime-objc
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
featherless retitled this revision from to Add composable performer guide to README.md..Sep 13 2016, 3:44 PM
featherless updated this object.
featherless edited the test plan for this revision. (Show Details)
Restricted Application added a project: Material Motion. · View Herald Transcript
featherless updated this revision to Diff 6691.Sep 13 2016, 3:45 PM
  • Remove trailing words.
featherless updated this revision to Diff 6693.Sep 13 2016, 3:57 PM
  • Add guide to toc.
rcameron added inline comments.
README.md
377

My performer needed to conform to PlanPerforming as well. Otherwise, add(plan:) was never called.

featherless updated this revision to Diff 6698.Sep 13 2016, 5:04 PM
featherless marked an inline comment as done.
  • More clearly call out that the composable performing protocol should be an additional protocol to be conformed to, not the only one.
appsforartists added inline comments.
README.md
348

"composition performer" sounds awkward. Does it have to be a special kind of performer to emit plans, or can any performer do that?

If you have to name it as a special case, "composing" might be a better part of speech.

396

Hooray guidance!

markwei accepted this revision.Sep 16 2016, 3:16 PM
markwei added a reviewer: markwei.
markwei added a subscriber: markwei.
markwei added inline comments.
README.md
348

It has to be a special kind of performer to emit plans.

Otherwise, the scheduler does not give your performer a TransactionEmitter to emit plans with.

This revision is now accepted and ready to land.Sep 16 2016, 3:16 PM
This revision was automatically updated to reflect the committed changes.